On 05/11/2007, Adriano Crestani <[EMAIL PROTECTED]> wrote: > I ran rat on the entire cpp trunk and got some thoughts about the results: > > 1-These files have no asf headers, however they have another lincense on it, > so I don't know if the asf headers should be inserted or not: > > tuscany/cpp/sca/runtime/core/xsd/wsdl_11.xsd > tuscany/cpp/sca/runtime/core/xsd/wsdl_11_http.xsd > tuscany/cpp/sca/runtime/core/xsd/wsdl_11_mime.xsd > tuscany/cpp/sca/runtime/core/xsd/wsdl_11_soap.xsd > tuscany/cpp/sca/runtime/core/xsd/wsdl_11_soap12.xsd >
These files should be left as they are. We need to add the licence from these into the NOTICE file in our root. > 2-There is no need to add asf header for this files, cause they have the > same meaning as NOTICE, README, LINCENCE, etc files, right?! > > tuscany/cpp/sca/README_ANT_INSTALL > tuscany/cpp/das/README_ANT_INSTALL > tuscany/cpp/sdo/README_ANT_INSTALL > If these are to be included in the distribution then they need the header. I think the info in here will go elsewhere in the documentation. > 3-These files are empty, could I delete them? > > tuscany/cpp/sca/samples/PHPCalculator/sample.calculator/runwsserver.bat > tuscany/cpp/sca/samples/PHPCalculator/sample.calculator/sample.calculator.composite.back > tuscany/cpp/sdo/runtime/core/src/commonj/sdo/DataObjectInstance.cpp > tuscany/cpp/sdo/runtime/core/src/commonj/sdo/DataObjectInstance.h > Yes, these can be deleted. > > 4-These files seems to be output of some test app, so I suspect that they > should be deleted, but I need somebody from SDO to confirm that: > > tuscany/cpp/sdo/runtime/core/test/querytest.txt > tuscany/cpp/sdo/runtime/core/test/saveopen-output.txt > tuscany/cpp/sdo/runtime/core/test/scenario1.txt > tuscany/cpp/sdo/runtime/core/test/scenario2.txt > tuscany/cpp/sdo/runtime/core/test/scenario3.txt > tuscany/cpp/sdo/runtime/core/test/scenario4.txt > tuscany/cpp/sdo/runtime/core/test/scenario5.txt > tuscany/cpp/sdo/runtime/core/test/sequence.txt > tuscany/cpp/sdo/runtime/core/test/setmany.txt > tuscany/cpp/sdo/runtime/core/test/setnull.txt > tuscany/cpp/sdo/runtime/core/test/showdefault1.txt > tuscany/cpp/sdo/runtime/core/test/showdefault2.txt > tuscany/cpp/sdo/runtime/core/test/simple.txt > tuscany/cpp/sdo/runtime/core/test/stock.xml > tuscany/cpp/sdo/runtime/core/test/stock_wsdl.txt > tuscany/cpp/sdo/runtime/core/test/stock_xml.txt > tuscany/cpp/sdo/runtime/core/test/testabstract.txt > tuscany/cpp/sdo/runtime/core/test/testerrors.txt > tuscany/cpp/sdo/runtime/core/test/testinc2.txt > tuscany/cpp/sdo/runtime/core/test/testopen.txt > tuscany/cpp/sdo/runtime/core/test/testorder.txt > tuscany/cpp/sdo/runtime/core/test/teststyles.txt > tuscany/cpp/sdo/runtime/core/test/testsubsload.txt > tuscany/cpp/sdo/runtime/core/test/testutils.txt > tuscany/cpp/sdo/runtime/core/test/testwsdl.txt > tuscany/cpp/sdo/runtime/core/test/travel.txt > tuscany/cpp/sdo/runtime/core/test/tuscany963.out.xml.txt > tuscany/cpp/sdo/runtime/core/test/userdata.txt > tuscany/cpp/sdo/runtime/core/test/xhtml_out.txt > tuscany/cpp/sdo/runtime/core/test/48736_xml.txt > tuscany/cpp/sdo/runtime/core/test/48736_xsd.txt > tuscany/cpp/sdo/runtime/core/test/b46633.txt > tuscany/cpp/sdo/runtime/core/test/b46634_out.txt > tuscany/cpp/sdo/runtime/core/test/b47137.txt > tuscany/cpp/sdo/runtime/core/test/b47137b.txt > tuscany/cpp/sdo/runtime/core/test/b47293.txt > tuscany/cpp/sdo/runtime/core/test/b48633_xml.txt > tuscany/cpp/sdo/runtime/core/test/b48636_xml.txt > tuscany/cpp/sdo/runtime/core/test/b48686_xml.txt > tuscany/cpp/sdo/runtime/core/test/b48686_xsd.txt > tuscany/cpp/sdo/runtime/core/test/badelement.txt > tuscany/cpp/sdo/runtime/core/test/bothgroups_xsd.txt > tuscany/cpp/sdo/runtime/core/test/bothgroupssamename_xsd.txt > tuscany/cpp/sdo/runtime/core/test/bug2.txt > tuscany/cpp/sdo/runtime/core/test/bug45933-output.txt > tuscany/cpp/sdo/runtime/core/test/bug48300_xml.txt > tuscany/cpp/sdo/runtime/core/test/bug48300_xsd.txt > tuscany/cpp/sdo/runtime/core/test/bunique-out.txt > tuscany/cpp/sdo/runtime/core/test/bunique-out.xsd_safe.txt > tuscany/cpp/sdo/runtime/core/test/bunique-outxml.txt > tuscany/cpp/sdo/runtime/core/test/buniqueread-out.txt > tuscany/cpp/sdo/runtime/core/test/carotest3.txt > tuscany/cpp/sdo/runtime/core/test/csload-output.txt > tuscany/cpp/sdo/runtime/core/test/csload2-output.txt > tuscany/cpp/sdo/runtime/core/test/csload3-output.txt > tuscany/cpp/sdo/runtime/core/test/cssave-output.txt > tuscany/cpp/sdo/runtime/core/test/cssave2-output.txt > tuscany/cpp/sdo/runtime/core/test/datetest.txt > tuscany/cpp/sdo/runtime/core/test/defaults.txt > tuscany/cpp/sdo/runtime/core/test/doctest.txt > tuscany/cpp/sdo/runtime/core/test/openloadNSout.txt > tuscany/cpp/sdo/runtime/core/test/openseq.txt > tuscany/cpp/sdo/runtime/core/test/order1.txt > tuscany/cpp/sdo/runtime/core/test/order2.txt > tuscany/cpp/sdo/runtime/core/test/notns.txt > tuscany/cpp/sdo/runtime/core/test/nulltest.txt > tuscany/cpp/sdo/runtime/core/test/oddchars.txt > tuscany/cpp/sdo/runtime/core/test/matttest1.txt > tuscany/cpp/sdo/runtime/core/test/merle1.txt > tuscany/cpp/sdo/runtime/core/test/maintest.txt > tuscany/cpp/sdo/runtime/core/test/list1_xml.txt > tuscany/cpp/sdo/runtime/core/test/list1_xsd.txt > tuscany/cpp/sdo/runtime/core/test/loadload-output.txt > tuscany/cpp/sdo/runtime/core/test/jira980_jungle_out.txt > tuscany/cpp/sdo/runtime/core/test/jira705_out.txt > tuscany/cpp/sdo/runtime/core/test/jira490.txt > tuscany/cpp/sdo/runtime/core/test/inc1.txt > tuscany/cpp/sdo/runtime/core/test/inc2.txt > tuscany/cpp/sdo/runtime/core/test/groupwithprefix_xsd.txt > tuscany/cpp/sdo/runtime/core/test/grouprefingroup_xsd.txt > tuscany/cpp/sdo/runtime/core/test/groupingroup_xsd.txt > tuscany/cpp/sdo/runtime/core/test/getproptest.txt > tuscany/cpp/sdo/runtime/core/test/emptycs1.txt > tuscany/cpp/sdo/runtime/core/test/emptycs2.txt > tuscany/cpp/sdo/runtime/core/test/emptycs3.txt > tuscany/cpp/sdo/runtime/core/test/csload-output.txt > tuscany/cpp/sdo/runtime/core/test/csload2-output.txt > tuscany/cpp/sdo/runtime/core/test/csload3-output.txt > tuscany/cpp/sdo/runtime/core/test/cssave-output.txt > tuscany/cpp/sdo/runtime/core/test/cssave2-output.txt > tuscany/cpp/sdo/runtime/core/test/datetest.txt > tuscany/cpp/sdo/runtime/core/test/defaults.txt > tuscany/cpp/sdo/runtime/core/test/doctest.txt > NO. DO NOT DELETE THESE!!! They are part of the SDO test suite data. > > 5-The ASF header were missing on these files and I added(revision: 591871) > it to them, some of them are .xml and seems to be result of some test app as > the files on thought 4-, however I just added the asf headers: > > tuscany/cpp/sdo/runtime/core/test/jira1112expected.xml > tuscany/cpp/sdo/runtime/core/test/jira980_mixedJungle_out.txt > tuscany/cpp/sdo/runtime/core/test/jira980_splitJungle_out.txt > tuscany/cpp/sdo/runtime/core/test/noschema.xml > tuscany/cpp/sdo/runtime/core/test/qualified.xml > tuscany/cpp/sdo/runtime/core/test/cdata-out.xml > tuscany/cpp/sdo/runtime/core/test/.cdtbuild > tuscany/cpp/sca/runtime/extensions/rest/Makefile.am > tuscany/cpp/das/runtime/core/include/apache/das/rdb/das_constants.h > tuscany/cpp/sca/runtime/extensions/rest/interface/src/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/interface/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/reference/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/reference/curl/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/reference/curl/src/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/service/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/service/httpd/Makefile.am > tuscany/cpp/sca/runtime/extensions/rest/service/httpd/src/Makefile.am > tuscany/cpp/sca/samples/HttpdBigBank/bigbank.wsclient/Makefile.am > tuscany/cpp/sca/samples/HttpdBigBank/httpserver/Makefile.am > tuscany/cpp/sca/samples/PHPCalculator/sample.calculator.client/env.sh > tuscany/cpp/sca/samples/PHPCalculator/sample.calculator.client/runclient_cpp.bat > tuscany/cpp/sca/samples/PHPCalculator/sample.calculator.client/runclient_cpp.sh > tuscany/cpp/sca/samples/RestCustomer/httpserver/Makefile.am > tuscany/cpp/sdo/runtime/core/src/.cdtbuild > tuscany/cpp/sdo/runtime/core/src/.cdtproject > tuscany/cpp/sdo/runtime/core/src/.project > tuscany/cpp/sdo/runtime/core/test/clone-out-win.xml > tuscany/cpp/sdo/runtime/core/test/clone-out.xml > tuscany/cpp/sdo/runtime/core/test/jira1112expected.xml > PLEASE remove the headers from any of the files you changed in sdo/runtime/core/test. These files are to compare test output and must match EXACTLY what is expected from the test. Best thing is to use svn to revert to the previous level. They do not need an ASF header in them. > Thoughts? > > Adriano Crestani > -- Pete --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
