On Jan 11, 2008 4:50 AM, <[EMAIL PROTECTED]> wrote:

> Author: lresende
> Date: Thu Jan 10 20:50:35 2008
> New Revision: 611046
>
> URL: http://svn.apache.org/viewvc?rev=611046&view=rev
> Log:
> TUSCANY-1936
>
> Modified:
>    incubator/tuscany/java/sca/tools/wsdl2java/pom.xml
>
> Modified: incubator/tuscany/java/sca/tools/wsdl2java/pom.xml
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/tools/wsdl2java/pom.xml?rev=611046&r1=611045&r2=611046&view=diff
>
> ==============================================================================
> --- incubator/tuscany/java/sca/tools/wsdl2java/pom.xml (original)
> +++ incubator/tuscany/java/sca/tools/wsdl2java/pom.xml Thu Jan 10 20:50:35
> 2008
> @@ -191,26 +191,6 @@
>     <build>
>         <plugins>
>             <plugin>
> -                <groupId>org.codehaus.mojo</groupId>
> -                <artifactId>build-helper-maven-plugin</artifactId>
> -                <version>1.0</version>
> -                <executions>
> -                    <execution>
> -                        <id>add-test-source</id>
> -                        <phase>generate-sources</phase>
> -                        <goals>
> -                            <goal>add-test-source</goal>
> -                        </goals>
> -                        <configuration>
> -                            <sources>
> -                                <source>target/sdo-source</source>
> -                                <source>target/wsdl2java-source</source>
> -                            </sources>
> -                        </configuration>
> -                    </execution>
> -                </executions>
> -            </plugin>
> -            <plugin>
>                 <groupId>org.apache.tuscany.sdo</groupId>
>                 <artifactId>tuscany-sdo-plugin</artifactId>
>                 <version>1.0-incubating-SNAPSHOT</version>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
> Hi Luciano

It looks like this means that we are no longer trying to compile the source
code that is generated as part of the generator test. I'm a little concerned
that this means that we are not checking that the generator generates valid
output. Looking at the tests though it doesn't seem that it does explicit
checks anyhow. So how about we build on your change here and do a textual
comparison of what was generated against what was expected to be generated?

Simon

Reply via email to