[ 
https://issues.apache.org/jira/browse/TUSCANY-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573725#action_12573725
 ] 

Simon Laws commented on TUSCANY-2055:
-------------------------------------

It seems that the Java Annotations and API V1 spec is a little inconsistent.

521 1.6.6.2. Accessing Conversation IDs from Clients
522 Whether the conversation ID is chosen by the client or is generated by the 
system, the client may access
523 the conversation ID by calling ServiceReference.getConversationID(). 

924 • getConversationID() - Returns the id supplied by the user that will be 
associated with
925 conversations initiated through this reference.

946 • getConversationID() - Returns the identifier for this conversation. If a 
user-defined identity had
947 been supplied for this reference then its value will be returned; otherwise 
the identity generated by
948 the system when the conversation was initiated will be returned.

Has there been more work to clarify in the spec group? 

I believe that the Conversation object represents the current conversation so 
you should always go there to get the current conversationID. The 
get/setConversationId on the ServiceReference is to allow the user to provide a 
conversation ID that will subsequently  be used for new conversations. Hence 
you won't get the current conversationID by calling getConversationId on 
ServiceReference you'll just get whatever you set there manually. 

Having said that I did a quick change to the test to make it retrieve the 
conversation ID from the Conversation object and needless to say it failed in 
other interesting ways. So if we can agree what the intention of the spec is 
I'll make the code do that.

> ServiceReference.getConversationID() not returning generated conversation IDs
> -----------------------------------------------------------------------------
>
>                 Key: TUSCANY-2055
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2055
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Specification
>    Affects Versions: Java-SCA-Next
>            Reporter: Kevin Williams
>            Assignee: Simon Laws
>
> ServiceReference.getConversationID() returns null unless the Conversation ID 
> is set by the user.
> This is the current  implementaiton:
>     public Object getConversationID() {
>         return conversationID;
>     }
> It seems that that if the cached ID is null, and there is a valid related 
> Converasation object then the impl should return the related 
> Conversation.getConversationID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to