On Wed, Mar 26, 2008 at 8:25 PM, Jean-Sebastien Delfino <
[EMAIL PROTECTED]> wrote:

> Luciano Resende wrote:
> > Please review and vote on the 1.2 release artifacts of Tuscany SCA for
> Java.
> >
> > The artifacts are available for review at:
> > http://people.apache.org/~lresende/tuscany/sca-1.2-RC2/<http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC2/>
> >
> >
> > This includes the signed binary and source distributions, the RAT
> report,
> > and the Maven staging repository.
> >
> > The eclipse updatesite for the Tuscany Eclipse plugins is available at:
> > http://people.apache.org/~lresende/tuscany/sca-1.2-RC2/updatesite/<http://people.apache.org/%7Elresende/tuscany/sca-1.2-RC2/updatesite/>
> >
> > The release tag is available at :
> > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.2-RC2/
> >
> > If you do find issues with the release candidate that you think need
> > to be fixed and lead to a -1 please review and fix them in the 1.2branch
> > or raise jira's targeting the 1.2 release.
> >
>
> It looks like the script used to change 1.2-incubating-SNAPSHOT to
> 1.2-incubating missed some files in the Eclipse plugins. I've created
> JIRA TUSCANY-2142 [1] to track that issue and describe a workaround.
>
> [1] http://issues.apache.org/jira/browse/TUSCANY-2142
> --
> Jean-Sebastien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
> I made a start by reviewing the binary distro.

I've been through all the samples and revisited the samples table on the
release page [1]. I created a demos table also. I created JIRA where I found
problems.

Licenses
=======

Some reformatting didn't get copied back from 1.1; primarily putting all
jars on separate lines with complete version numbers. These are the diffs I
found

LICENSE                       /lib
                              geronimo-activation_1.0.2_spec-1.1.jar
jaxen-1.1-1.jar               jaxen-1.1.1.jar
Groovy                        groovy-all-minimal-1.5.4.jar
Jython                        jython-2.2.jar
jsr181-api                    jsr181-api-1.0-MR1.jar
jsr250-api                    jsr250-api-1.0.jar
mail                          mail-1.4.jar
saaj-api                      saaj-api-1.3.jar
wsdl4j                        wsdl4j-1.6.2.jar
backport-util-concurrent:     backport-util-concurrent-2.2.jar
serp                          serp-1.12.0.jar
axion                         axion-1.0-M3-dev.jar
javacc                        javacc-3.2.jar
howl                          howl-1.0.1-1.jar
dojotoolkit
activeio-core-3.0.0-incubator.jar
activemq-core-4.1.1.jar
addressing-1.3.mar
axis2-adb-codegen-1.3.jar
maven-artifact-2.0.2.jar
maven-artifact-manager-2.0.2.jar
maven-error-diagnostics-2.0.2.jar
maven-model-2.0.2.jar
maven-profile-2.0.2.jar
maven-project-2.0.2.jar
maven-repository-metadata-2.0.2.jar
maven-settings-2.0.2.jar
opensaml-1.1.jar
wagon-file-1.0-alpha-7.jar
wagon-http-lightweight-1.0-alpha-6.jar
wagon-provider-api-1.0-alpha-6.jar
xbean-2.1.0.jar
xmlParserAPIs-2.6.2.jar

Junk files
=======

.\demos\bigbank\src\main\resources\web\dojo
./tutorial/store-db/target/cart-db/log
./tutorial/store-eu/target/cart-eu-db/log
./tutorial/store-supplier/target/cart-db/log
./samples/calculator-webapp/target/war/work
./samples/calculator-ws-webapp/target/war/work
./samples/chat-webapp/target/war/work
./samples/feed-aggregator-webapp/target/war/work
./samples/helloworld-dojo-webapp/target/war/work
./samples/helloworld-jsonrpc-webapp/target/war/work
./samples/helloworld-ws-sdo-webapp/target/war/work
./tutorial/store-db/target/cart-db/tmp
./tutorial/store-eu/target/cart-eu-db/tmp
./tutorial/store-supplier/target/cart-db/tmp

RAT
====

output hard to read as it reports on all the dojo files. I did spot..

 =======================================================================
 
==./modules/interface-java-jaxws/src/test/java/org/apache/tuscany/sca/interfacedef/java/jaxws/Bean.java
 =======================================================================
 package org.apache.tuscany.sca.interfacedef.java.jaxws;

public interface Bean<T> {
    public T getP1();
}

 =======================================================================
 
==./modules/interface-java-jaxws/src/test/java/org/apache/tuscany/sca/interfacedef/java/jaxws/Bean1.java
 =======================================================================
 package org.apache.tuscany.sca.interfacedef.java.jaxws;

public class Bean1 {
    private String p1;
    private int p2;
    public String getP1() {
        return p1;
    }
    public void setP1(String p1) {
        this.p1 = p1;
    }
    public int getP2() {
        return p2;
    }
    public void setP2(int p2) {
        this.p2 = p2;
    }
}

 =======================================================================
 
==./modules/interface-java-jaxws/src/test/java/org/apache/tuscany/sca/interfacedef/java/jaxws/Bean2.java
 =======================================================================
 package org.apache.tuscany.sca.interfacedef.java.jaxws;

public class Bean2 implements Bean<String>{
    private String p1;
    private int p2;
    public String getP1() {
        return p1;
    }
    public void setP1(String p1) {
        this.p1 = p1;
    }
    public int getP2() {
        return p2;
    }
    public void setP2(int p2) {
        this.p2 = p2;
    }
}

Other
====

lib/wstx-asl-3.2.1.jar appears twice
expected results very rarely match as logging changes quite frequently -
shall we remove expected results from README files?
README/INSTALL/RELEASE_NOTES/CHANGES - have wrong date
INSTALL doesn't mention tutorial directory

I'll make a start on JIRA items.

Regards

Simon

[1]
http://cwiki.apache.org/confluence/display/TUSCANYWIKI/Release+-+Java+SCA+1.2

Reply via email to