To summarize i think you're saying that the blocking issues are (assuming
the jetty problems were a transient maven thing):

- the LICENSE file, (eg
https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1/sdo-api/src/main/resources/META-INF/LICENSE)
has the a comment at the start sayiny "Each file in this JAR is covered by
one of the two liceses listed below."

- the NOTICE file includes the comment about section 4d of the AL, eg
https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1/sdo-api/src/main/resources/META-INF/NOTICE

Neither of these seem like blockers to me, i'll respin if others disagree
but IMHO its safe to leave these to be fixed in the next release, the NOTICE
comment is endemic in many other Apache releases and has only just come to
light on other mailing lists, i don't think a one release grace period will
hurt. What do others think?

   ...ant

On Thu, Mar 27, 2008 at 5:08 PM, sebb <[EMAIL PROTECTED]> wrote:

> On 24/03/2008, ant elder <[EMAIL PROTECTED]> wrote:
> > There is an RC3 for the SDO 1.1 release available at
> > http://people.apache.org/~antelder/tuscany/sdo/1.1-rc3/<http://people.apache.org/%7Eantelder/tuscany/sdo/1.1-rc3/>
> .
> >
> > This RC addresses the issues raised against the RC2 release, I'll start
> > votes on this shortly but in the meantime any reviews to sanity check
> the
> > artifacts would be appreciated.
> >
> > Thanks!
> >
> > Sebb, any chance you could take a look to see if this resolves the
> things
> > you brought up on the RC2 release?
> >
>
>  source archive
> ===========
>
> The source archive contains the directory
>
> impl/.felix
>
> which is not in SVN; it should not be there.
> As it's empty, not a blocker; the rest of the source archive looks OK
>
> The NOTICE file contains the sentence:
>
> "Please see the LICENSE file present in the root directory of this
> distribution."
>
> This should be removed (not a blocker).
>
> pom.xml has some formatting problems; the plugin management section
> uses tabs which destroy the alignment for me at least. Not a blocker.
>
> pom.xml defines the target and source versions as 1.4. However,
> BUILDING refers to needing 1.5 for "one value add (sic) component",
> and says one must use "mvn -Pjava_1_4_maven" to build with Java 1.4.
> This is the wrong way round. The user should not have to do something
> special to build with Java 1.4 if the build is targetted at Java 1.4.
>
> I think this is potentially a blocker.
>
> Build and test works OK with Java 1.5.
>
> However build/test fails when using Java 1.4, even when using the Java
> 1.4 work-round mentioned above.
>
> =====================
>
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Failed to resolve artifact.
>
> Missing:
> ----------
> 1) org.mortbay.jetty:jetty-util:jar:2.4.1
>
>  Try downloading the file manually from the project website.
>
>  Then, install it using the command:
>      mvn install:install-file -DgroupId=org.mortbay.jetty
> -DartifactId=jetty-util -Dversion=2.4.1 -Dpackaging=jar
> -Dfile=/path/to/f
> ile
>
>  Alternatively, if you host your own repository you can deploy the file
> there:
>      mvn deploy:deploy-file -DgroupId=org.mortbay.jetty
> -DartifactId=jetty-util -Dversion=2.4.1 -Dpackaging=jar
> -Dfile=/path/to/fil
> e -Durl=[url] -DrepositoryId=[id]
>
>  Path to dependency:
>        1)
> org.apache.maven.plugins:maven-site-plugin:maven-plugin:2.0-beta-6
>        2) org.mortbay.jetty:jetty:jar:6.1.5
>        3) org.mortbay.jetty:jetty-util:jar:2.4.1
>
> 2) org.mortbay.jetty:servlet-api-2.5:jar:2.4.1
>
>  Try downloading the file manually from the project website.
>
>  Then, install it using the command:
>      mvn install:install-file -DgroupId=org.mortbay.jetty
> -DartifactId=servlet-api-2.5 -Dversion=2.4.1 -Dpackaging=jar
> -Dfile=/path
> /to/file
>
>  Alternatively, if you host your own repository you can deploy the file
> there:
>      mvn deploy:deploy-file -DgroupId=org.mortbay.jetty
> -DartifactId=servlet-api-2.5 -Dversion=2.4.1 -Dpackaging=jar
> -Dfile=/path/t
> o/file -Durl=[url] -DrepositoryId=[id]
>
>  Path to dependency:
>        1)
> org.apache.maven.plugins:maven-site-plugin:maven-plugin:2.0-beta-6
>        2) org.mortbay.jetty:jetty:jar:6.1.5
>        3) org.mortbay.jetty:servlet-api-2.5:jar:2.4.1
>
> ----------
> 2 required artifacts are missing.
>
> for artifact:
>  org.apache.maven.plugins:maven-site-plugin:maven-plugin:2.0-beta-6
>
> from the specified remote repositories:
>  central (http://repo1.maven.org/maven2),
>  apache.incubator (http://people.apache.org/repo/m2-incubating-repository
> ),
>  apache.snapshots (http://people.apache.org/repo/m2-snapshot-repository),
>  codehaus-snapshot (http://snapshots.repository.codehaus.org),
>  indiana (http://ftp.ussg.iu.edu/eclipse/modeling/emf/emf/maven2/)
>
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 28 seconds
> [INFO] Finished at: Thu Mar 27 13:53:57 GMT 2008
> [INFO] Final Memory: 14M/25M
> [INFO]
> ------------------------------------------------------------------------
>
> ========================
>
>
> This is a blocker.
>
> SVN (https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sdo/1.1/
> )
> ====
> There are quite a few missing SVN properties on the source files; see
> the attached script.
> Not a blocker.
>
> Binary archive
> ==========
> The manifest file is rather rudimentary; it should contain project and
> version details, and compiler source and target as a minimum.
>
> There should only be one manifest.
>
> Maven jars
> ========
> tuscany-sdo-api-r2.1-1.1-incubating.jar:
> - LICENSE is not correct. Should start with AL 2.0, then add other
> licenses at end as needed.
> - NOTICE file is incorrect; should not contain the blurb about
> "section 4 d"; should also not refer to LICENSE file
> - README refers to February 2008 (not a blocker)
> - manifest is messy, but contains reasonable info (java compiler,
> target and source, implementation version)
>
> tuscany-sdo-impl-1.1-incubating.jar
> tuscany-sdo-java5tools-1.1-incubating.jar
> - NOTICE file - same problem as above
> - Manifest - insufficient information
>
> tuscany-sdo-lib-1.1-incubating.jar
> - NOTICE file - same problem as above
> - Manifest - good; others should have the same attributes
>
> tuscany-sdo-plugin-1.1-incubating.jar
> tuscany-sdo-tools-1.1-incubating.jar
> - NOTICE file - same problem as above
> - Manifest - could be better
>
> The L & N problems are blockers, IMO.
> If further clarification is needed, may I suggest posting a question
> on the Legal-discuss list?
>
> Tried building
> >    ...ant
> >
> >
>

Reply via email to