[
https://issues.apache.org/jira/browse/TUSCANY-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584783#action_12584783
]
Kevin Williams commented on TUSCANY-2188:
-----------------------------------------
Gilbert, this looks great and I just committed your contribution. A few small
comments:
1 - I created a jira (T-2191) for the test you have "@ignored".
2 - I reformatted the code based on the Tuscany guidelines. You can find
formatting templates for various IDE's here:
https://svn.apache.org/repos/asf/incubator/tuscany/java/etc/
3 - I modified your "atService6" test to make use of junits "fail" feature. I
think this is more straightforward.
4 - I am not sure that atService8 is working as intended since I don't see you
explicitly use the name of the service.
I'll leave this jira open until we resolve #4
Thanks!
> New tests for Java @Service annotaion
> --------------------------------------
>
> Key: TUSCANY-2188
> URL: https://issues.apache.org/jira/browse/TUSCANY-2188
> Project: Tuscany
> Issue Type: Test
> Components: Java SCA Verification Tests
> Affects Versions: Java-SCA-Next
> Reporter: Kevin Williams
> Assignee: Kevin Williams
> Attachments: patch.txt, service.zip
>
>
> New tests for Java Common Annotations and APIs Specification of @Service
> annotation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
