[ 
https://issues.apache.org/jira/browse/TUSCANY-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593632#action_12593632
 ] 

Kevin Williams commented on TUSCANY-2286:
-----------------------------------------

Thanks for contributing this test for the @init annotation. 

Unfortunately, I am unable to apply your patch file.  The error I get (using 
TortiseSVN) is :

"An unknown line type was found in line 51!"  This may have to do with the 
inclusion of property changes in the patch.

I did take a scan through the content and wonder if you could make changes to 
your patch to be more consistent with the existing tests.? We have been using 
conventions for service names and components and test structure and I hope to 
keep this consistent throughout the bucket.   We have also been using a javadoc 
convention on the test cases to explicitly call out the specification line 
numbers that each test addresses.

Thanks again!

> Add vtest for @Init annotation
> ------------------------------
>
>                 Key: TUSCANY-2286
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2286
>             Project: Tuscany
>          Issue Type: Test
>          Components: Java SCA Verification Tests
>            Reporter: Vamsavardhana Reddy
>            Assignee: Vamsavardhana Reddy
>             Fix For: Java-SCA-Next
>
>         Attachments: TUSCANY-2286.patch
>
>
> Add verification tests for @Init annotation.
> Java Common Annotations and APIs v1.00 - Section 1.8.11 - Lines 1290 to 1293:
> 1290 The @Init annotation type is used to annotate a Java class method that 
> is called when the scope defined for
> 1291 the local service implemented by the class starts. The method must have 
> a void return value and no
> 1292 arguments. The annotated method must be public. The annotated method is 
> called after all property and
> 1293 reference injection is complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to