Hello,
I was browsing the Tuxdroïd's Python API and noticed two big functions,
namely store() and restore(), whose roles are to "save" the contents of
on_xxx members to s_on_xxx members and copy back s_on_xxx to on_xxx
later, respectively.
They don't seem to be used anywhere, though, so I'm willing to remove
them entirely. However, if there's a good reason to keep them, I would
rewrite them more concisely, something along the lines of:
def store(self):
members = [m for m in self.__dict__ if m[:3] == "on_"]
for m in members:
self.__dict__["saved_" + m] = self.__dict__[m]
def restore(self):
members = [m for m in self.__dict__ if m[:3] == "on_"]
for m in members:
self.__dict__[m] = self.__dict__["saved_" + m]
And maybe even return the "saved" state instead of storing it within
the object.
This could be applied to clear() as well:
def clear(self):
for member in self.__dict__:
if member[:3] == "on_":
self.__dict__[member] = None
The problem with in doing so is that currently the objects have both
variables and methods with the same name: on_status and on_status(),
for example. Thus it would require to rename either of these.
Comments ?
Damien
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
tux-droid-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tux-droid-user
