On Jul 2, 2011 10:28 p.m., "Glyph Lefkowitz" <gl...@twistedmatrix.com> wrote: > > > On Jul 2, 2011, at 1:07 PM, Michael Thompson wrote: > >> On 1 July 2011 18:38, Glyph Lefkowitz <gl...@twistedmatrix.com> wrote: > > >> I think github means less effort for the reviewer because they can >> review commits, rather than a large diff. They can review changes >> following a review. > > > I already review diffs this way, with a local bzr-svn branch using 'bzr merge; bzr qlog'. Better yet I just sometimes do this on a plane :). >
Is that reviewing Svn branches what about text patches? If I address three review comments sending in three patch files seems like a hassle for me and the reviewer and could lead to more delays in the review process.
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
