On Jul 12, 2013, at 5:09 AM, exar...@twistedmatrix.com wrote: > On 10:42 am, p.may...@imperial.ac.uk wrote: >> On 12/07/13 11:34, Itamar Turner-Trauring wrote: >>> Subclass twisted.internet.tcp.Client, override createInternetSocket() so >>> it calls setsockopt() on the socket after you've called base >>> implementation to create it. This breaks some abstraction boundaries, so >>> it isn't great, but very little code duplication is involved. >> >> Ah, ok. Presumably I also need to subclass Connector and override >> _makeTransport to use MyClient, then call MyConnector() directly (or >> subclass the reactor... shudder) >> >> Should there be something built in to Twisted for this? Should I open a >> ticket? > > If you want your code to keep working, or to work with alternate reactor > implementations, then you'd *really* rather use a documented, tested > interface rather than the hack outlined above.
Does such an API exist today, or should a ticket be filed for one? For everyone's information, in case it's not entirely clear from the documentation resources available: we hope to eventually deprecate the whole 'tcp' module so that people (myself included ;-)) stop subclassing stuff in it, so writing new code that depends on this, even the nominally "public" parts of the API (the bits without underscores) would be really unfortunate. If we can figure out something that uses totally public APIs without subclassing tcp.Client that would be best; if not, we should really have a ticket open to fix the API so that it is possible. -glyph
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
