On 2014-08-21 22:24, Rob Oakes wrote:
> a. Which of the two websocket branches should be used as the basis for new > work? > > On GitHub, websocket-4173-4 is marked as closed with a note telling the > contributor to see the contribution guidelines. There are also several > additions to the code which do not follow Twisted conventions (as I > understand them). The last set of commits also seem to come from > approximately the same time. > > websocket-4173-4 includes code which attempts to resolve issues noted in 4173 > that is not present in 4173-3, but there aren't really any comments to > determine if this should be incorporated or not. At this point, I'm really > not familiar enough with the code to draw my own conclusion. I'm not sure what you mean by "the branch is marked as closed" - AFAIK GitHub has no concept of closing branches. Plus GitHub is just a mirror. If -4 is the latest revision in Subversion then that's the latest version of the code. -Itamar
_______________________________________________ Twisted-Python mailing list [email protected] http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
