> On Jan 26, 2015, at 7:56 AM, Adi Roiban <[email protected]> wrote:
>
> On 26 January 2015 at 04:00, Glyph <[email protected]> wrote:
>>
>> On Jan 25, 2015, at 7:28 AM, [email protected] wrote:
>>
>>
>> This test has intermittently failed on Windows since disttrial was merged
>> into trunk.
>>
>>
>> And, as you yourself pointed out on the ticket, sometimes on Linux too.
>>
>> I still have absolutely no clue why this happens, by the way. If anyone
>> else could be prompted to investigate I would be much obliged
>
> I have updated my findings here: https://twistedmatrix.com/trac/ticket/6027
> <https://twistedmatrix.com/trac/ticket/6027>
Thanks for looking into it.
>> The default state of a test should *not* be to skip. It should be to run.
>> A skipped test is a useless test.
>>
>> As a matter of general principle, the only reason a test should ever be
>> skipped within Twisted is if an optional dependency is not available. And,
>> just to be clear, the presence of "TODO'd" tests is pretty much just a bug,
>> fix old ones and never add new ones :-).
>
> I think that these todo are just another way of creating a ticket ...
> with a promise to annoy you forever
And to annoy every contributor ever who works on something unrelated :).
> Would it help if I extract them into proper Trac tickes and clean the code?
Some of them are already filed, but... yes, having a ticket for every one would
be helpful.
In fact, we might want to have two tickets for each one: one "delete this
todo'd test" ticket, and one "actually fix this issue" ticket, since we don't
need to keep hanging on to the tests in the repo themselves while we wait for
someone to take care of the issues.
> --------
>
> Maybe update docs and stress that todo tests should not be committed
> ... or never mention about such thing as TODO markers,
> I just write tests and expect them to fail without marking them as todo.
>
> http://twistedmatrix.com/documents/current/core/development/policy/test-standard.html
>
> (not sure why some docs are on wiki and others in the repo)
There's no really good reason, that's just where things are. Probably
everything should move into the repo.
> And maybe also add a twistedchecker check and check that no new tests
> are commited with todo.
If you wanted to add that it would definitely be helpful.
-glyph
_______________________________________________
Twisted-Python mailing list
[email protected]
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
