On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban <a...@roiban.ro> wrote: > > > Only the modules (including the test modules) from dist3.py are executed > on Python3 > https://github.com/twisted/twisted/blob/trunk/twisted/python/dist3.py > > In the header of that file you can see > > # -*- test-case-name: twisted.python.test.test_dist3 -*- > > and also in the test modules we have > > twisted.python.test.test_dist3 > > --------------- > > That is you need to make the changes in that module > > twisted.python.test.test_dist is not executed on Python3 ... hence its > coverage is not reported on Python3 > >
In https://github.com/twisted/twisted/pull/224 , I made no changes to twisted/python/dist3.py, so making changes to test_dist3.py will not help. I added twisted.python.test.test_dist to the list of tests executed on Python 3 in https://github.com/twisted/twisted/pull/288 and that fixed the coverage problem. I still think that setup.py should be invoked under coverage (I assume in tox.ini) in the coverage build, without writing a separate test for setup.py -- Craig
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python