Hi Wim,
Thanks for following the process. Glad to see that this got resolved. And
thanks for cleaning up our TERRIBLE HACKs :).
-g
> On Mar 7, 2018, at 2:12 AM, Adi Roiban <a...@roiban.ro> wrote:
>
> Hi,
>
> Thank you so much Wim for helping with this cleanup.
>
> As commented in the PR I am +1 for this exceptions.
>
> Cheers,
> Adi
>
> On 6 March 2018 at 20:20, Wim Lewis <w...@omnigroup.com> wrote:
>> In PR 949 ("Remove “terrible hack” in
>> t.c.ssh.filetransfer.FileTransferClient", trac bug 9362) I'm removing an
>> attribute of FileTransferClient which I'm pretty sure was never intended to
>> be public. Adi Roiban points out that this is technically a
>> compatibility-breaking change, though, and so it needs more public review.
>>
>> My reasoning for thinking that this will not break any user code: the
>> attribute, although not prefixed with an underscore, was undocumented;
>> anyone relying on it would have had to read the source code to discover what
>> it does, and in the source it was commented as a "TERRIBLE HACK". I'd hope
>> this would be enough of a warning. (Also, I can't think of a use for it.)
>>
>> trac: https://twistedmatrix.com/trac/ticket/9362
>> pr: https://github.com/twisted/twisted/pull/949
>>
>>
>> _______________________________________________
>> Twisted-Python mailing list
>> Twisted-Python@twistedmatrix.com
>> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
>
> --
> Adi Roiban
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
