On 1/07/2020 1:41 am, Barry Scott wrote:
On Saturday, 27 June 2020 07:47:14 BST Ian Haywood wrote:


I've been told in code review to use composition instead of inheritance,
which is fine in a general sense but I have difficulty applying to
twisted-specific task



thanks for these pointers everyone.

I have changed the code in my PR to remove the subclass-of-a-subclass.

I'm now looking for a committer who is able to review it again.

https://github.com/twisted/twisted/pull/1274

Ian

_______________________________________________
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Reply via email to