Arno,

>I do not think that people use multiple log destinations at the
>same time. Currently the string is allocated and concatenated
>only when actually required.
But it's possible. My modification is more compact also.

>This is non-optimal as well.
>You always concatenate and allocate the string even though it's
>not used. That sure leads to smaller source code but only performs 
>faster _if you actually write to multiple log destinations. 
Where? I concatenate it _only_ if loAddStamp is set and it's the same as 
execute procedure with AddTimeStamp + Msg.
Maybe you mean that additional concatenation with #13#10? I think it would be 
better to move this to WriteToLogFile because newline is added before call to 
this method anyway.
Moreover I think additional check should be added to determine whether newline 
is already present in Msg - in that case it shouldn't attach another one.

-- 
Anton
--
To unsubscribe or change your settings for TWSocket mailing list
please goto http://lists.elists.org/cgi-bin/mailman/listinfo/twsocket
Visit our website at http://www.overbyte.be

Reply via email to