On 2025-08-31 03:06, Dag-Erling Smørgrav wrote:
do you have any plans to do anything about the inconsistent indentation and widespread use of the register keyword?
For style reasons Arthur David Olson prefers "register" as it prevents taking the address of a local variable, so I keep "register" in code that already has it. To me the style doesn't seem worth the maintenance hassle, so I don't use it in newer code.
Although C++17 removed "register", TZDB code does not conform to C++17 in many other ways, and there seems little need for the maintenance hassle to make it conform as everybody that has a C++ compiler also has access to a C compiler.
For indentation, I use a similar rule: leave old code alone, and in new code use an arguably better style that allows more levels of indentation. "Arguably" as some argue that extra levels are bad. Not sure it's worth the maintenance hassle of reindenting the old code.
