Paul Eggert via tz <[email protected]> writes: > * localtime.c (localtime): Add comment re difference from FreeBSD 15.1. > [...] > + /* Omit "tzloadflags &= ~TZLOAD_FROMENV;" here, as that > + would hurt performance by rereading and reanalyzing the > + TZDEFAULT file even when it is unchanged. */
This is not accurate. TZLOAD_FROMENV was originally used to indicate that the value of `name` came from the environment and should therefore be subject to additional scrutiny. At some point between 2025a and 2025c, it was robbed of its original meaning and turned into a flag that controls change detection. No explanation has ever been provided for the change in meaning of the flag, or the loss of its original function, This comment does not help matters. The function that the flag originally served is still gone. The comment does not explain the purpose of the flag, it just attacks FreeBSD for still having a line of code that used to be necessary but now does something completely different *only because you changed the meaning of this flag overnight without warning or explanation, and then refused to help when I approached you about it*. This pattern of condescending remarks and passive-aggressive attacks against FreeBSD in code comments and commit logs is beneath you, Paul. Please do better. DES -- Dag-Erling Smørgrav - [email protected]
