In message <[EMAIL PROTECTED]> you wrote:
> Moved some code to nestal/common/nm_bsp.c.
> Added support for the vxWorks EDR.
> Enable trace for Lauterbach, if present.
> Added support for POST.
...
> + if (mfspr(dbcr0) & 0x80000000) { /* External debugger alive */
> + /* enable trace facilty for Lauterback
/*
* enable trace facilty for Lauterbach
...
> - /*-------------------------------------------------------------------+
> - | Set priority for all PLB3 devices to 0.
> - | Set PLB3 arbiter to fair mode.
> - +-------------------------------------------------------------------*/
> + /*-------------------------------------------------------------------
> + * Set priority for all PLB3 devices to 0.
> + * Set PLB3 arbiter to fair mode.
> + *-------------------------------------------------------------------*/
...
> - /*-------------------------------------------------------------------+
> - | Set priority for all PLB4 devices to 0.
> - +-------------------------------------------------------------------*/
> + /*-------------------------------------------------------------------
> + * Set priority for all PLB4 devices to 0.
> + *-------------------------------------------------------------------*/
If you change multiline comments, then please do it right. The
preferred style for long (multi-line) comments is:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
> + /* TLB#12: */
> + tlbentry( CFG_CS_2 + 0x1000000, SZ_16M, CFG_CS_2 + 0x1000000, 1,
> AC_R|AC_W|AC_X|SA_G|SA_I )
Here and in some other places: please mind the maximum line length.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
"If the code and the comments disagree, then both are probably
wrong." - Norm Schryer
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users