On 1/16/08, Jon Loeliger <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-15 at 16:59, Grant Likely wrote:
>
> > Nit: Don't do it this way; do this instead (to match the style used in
> > other Makefiles):
> >
> > +COBJS-y := pq-mds-pib.o
> > +COBJS-${CONFIG_ID_EEPROM} += sys_eeprom.o
> > +COBJS-${CONFIG_FSL_DIU_FB} += fsl_diu_fb.o fsl_logo_bmp.o
> > +COBJS-${CONFIG_FSL_PIXIS} += pixis.o
> >
> > -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
>
> So, are you going to submit a patch to convert
> them all to be like that then?
>
> I looked at this one in drivers/net:
>
Hmm, I missed that when drivers/Makefile was split up into the
subdirectories. When I first split up the COBJS, I eliminated COBJS
entirely in favor of COBJS-y. It's not a big deal though.
However, I would at the very least change this:
COBJS := pq-mds-pib.o
to this:
COBJS=y += pq-mds-pib.o
So that all obj files are added in the same way.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
