Hi Niklaus, On Thursday 17 January 2008, Niklaus Giger wrote: > Thanks for fixing the compile warnings. I fixed my compilation script to > look for warnings in order to fix these kind of problems before submitting > to the u-boot list.
Good. And please keep me on CC on such mails/patches. Makes it easier for me to spot things. > [..] > > > diff --git a/board/netstal/hcu4/Makefile b/board/netstal/hcu4/Makefile > > index c0d719f..b13d9d4 100644 > > --- a/board/netstal/hcu4/Makefile > > +++ b/board/netstal/hcu4/Makefile > > @@ -27,11 +27,11 @@ vpath hcu_flash.c ../common > > vpath nm_bsp.c ../common > > > > # NOBJS : Netstal common objects > > -NOBJS = fixed_sdram.o hcu_flash.o nm_bsp.o > > +NOBJS = ../common/fixed_sdram.o ../common/hcu_flash.o \ > > ../common/nm_bsp.o > > COBJS = $(BOARD).o > > SOBJS = > > > > -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) ../common/$(NOBJS:.o=.c) > > +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(NOBJS:.o=.c) > > OBJS := $(addprefix $(obj),$(COBJS)) > > NOBJS := $(addprefix $(obj),$(NOBJS)) > > SOBJS := $(addprefix $(obj),$(SOBJS)) > > I think that your fixes for the Makefiles are wrong, as they do not work > when one wants to compile out-of-tree. E.g if I specify O=../build, then I > get errors like > FATAL: can't create > /home/ng/u-boot/build/board/netstal/hcu5/../common/hcu_flash.o: No such > file or directory Right, I missed this. > Is it okay if I submit a patch to revert the changes or do you suggest > another way how to fix the Makefiles? No, please don't revert my fixes, since my patch also changes other issues. Please send a new patch which really fixes only this problem. Not your previous version, since this had compile warnings too. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
