Hi Mark, Mark Jonas wrote: > Hello, > > the attached patch adds a driver for the SMSC LAN911x and LAN921x > family of Ethernet controllers. The patch also > enables the use of this driver on the SH7720 based MPR2 board. > > Please note that the network driver does not obey the U-Boot coding > style at all. The reason is that the driver is > supplied like that by SMSC on their web page. I only modified it such > that it not only supports the LAN9x18 but > also the LAN9x15. And I removed CRLFs. > > My reasoning for leaving the driver as is that if SMSC updates the > driver on their web page it will be easier to > get the changes into U-Boot as well. > > Your intentions are good, but you have to know that there's no way this driver is going into U-boot unless it meets the coding standards. There are many reasons for this policy, but suffice to say it just ain't gonna happen.
If you clean it up, we'll put it in. Also, sending patches zipped up is uncool. Please send as inline text and break up logically if you need to. regards, Ben ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
