In message <[EMAIL PROTECTED]> you wrote:
> This patch adds an U-Boot command, ambapp, which prints a summary
> of AMBA Bus Plug & Play information.
...
> diff --git a/common/Makefile b/common/Makefile
> index a88d1ef..3d369ff 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -91,6 +91,7 @@ COBJS-$(CONFIG_CMD_STRINGS) += cmd_strings.o
> COBJS-$(CONFIG_CMD_TERMINAL) += cmd_terminal.o
> COBJS-$(CONFIG_CMD_UNIVERSE) += cmd_universe.o
> COBJS-$(CONFIG_CMD_USB) += cmd_usb.o
> +COBJS-y += cmd_ambapp.o
Please compile the code only for boards that enable it in the
configuration.
> diff --git a/common/cmd_ambapp.c b/common/cmd_ambapp.c
> new file mode 100644
> index 0000000..5329a3a
> --- /dev/null
> +++ b/common/cmd_ambapp.c
...
...
> +#include <common.h>
> +#include <command.h>
> +
> +#if defined(CONFIG_CMD_AMBAPP)
This should not be needed any more, then.
> +#ifndef CONFIG_LEON3
> +#error Only LEON3 processors support the AMBA Plug&Play bus
> +#endif
> +
> +#include <ambapp.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* We put these variables into .data section so that they are
> + * zero when entering the AMBA Plug & Play Section the first time.
> + * BSS is not garantueed to be zero since BSS hasn't been cleared
> + * the first times entering the AMBA functions.
> + */
Um.... when would that be? Command code like this cannot be executed
before relocation to RAM, and by then the BSS *is* zeroed.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Good manners are the settled medium of social, as specie is of
commercial, life; returns are equally expected for both.
- Lord Chesterfield _Letters to his Son_, 25 December 1753
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
