Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> writes:
>> +
>> + reg16 = in_le16(hose_cfg_base + PEX_LTSSM_STAT);
>> + if (reg16 < 0x16) {
>> + printf("No link\n");
>> + hose->indirect_type = INDIRECT_TYPE_NO_PCIE_LINK;
>> + } else {
>> + printf("link\n");
>> + }
> please remove the bracket on the else
Come on, this is being ridiculously pedantic.
And wrong by Linux coding style. Quoting from Documentation/CodingStyle
Do not unnecessarily use braces where a single statement will do.
if (condition)
action();
This does not apply if one branch of a conditional statement is a single
statement. Use braces in both branches.
if (condition) {
do_this();
do_that();
} else {
otherwise();
}
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
