Hi Ben, On Wed, 26 Mar 2008, Ben Warren wrote:
> Hi Guennadi, > > Guennadi Liakhovetski wrote: > > From: Sascha Hauer <[EMAIL PROTECTED]> > > > > This patch adds a driver for the following smsc network controllers: > > LAN9115 > > LAN9116 > > LAN9117 > > LAN9215 > > LAN9216 > > LAN9217 > > > > > How many of these have been tested, and on what platforms. I'm asking because > the code seems to assume a 32-bit interface and these aren't all 32-bit chips. I'll let the author reply to all your question / take care of all your suggestions, apart, maybe from just one: > > +#define TX_CMD_A_INT_LAST_SEG (0x00001000) > > +#define TX_CMD_A_BUF_SIZE (0x000007FF) > > +#define TX_CMD_B_PKT_TAG (0xFFFF0000) > > +#define TX_CMD_B_ADD_CRC_DISABLE (0x00002000) > > +#define TX_CMD_B_DISABLE_PADDING (0x00001000) > > +#define TX_CMD_B_PKT_BYTE_LENGTH (0x000007FF) > > + > > > Register and bitfield definitions should be in a header file. More generally, I disagree with this. If only one .c file uses registers and bitfields and whatever other macros, I think, they better be defined in the .c file directly. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
