In message <[EMAIL PROTECTED]> you wrote:
> bugfix: the watchdog post for lwmon5 doesn't work. This Patch fix it.
> To trigger and activate the watchdog correct it is necessary to create 2
> pulses.
> Lowpegel on GPIO62 point to a voltagefailure.
Please fix English ("correct", "Lowpegel", "voltagefailure").
Is it really 2 pulses - or just one, consisting of
> Signed-off-by: Sascha Laue <[EMAIL PROTECTED]>
...
> - if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
> + if (0 == gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
Please write that as:
if (gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS) == 0) {
or
if (!gpio_read_in_bit(CFG_GPIO_SYSMON_STATUS)) {
> * 3.1. GPIO62 is low
> * Assuming system voltage failure.
> @@ -99,6 +99,9 @@ int lwmon5_watchdog_post_test(int flags)
> ints = disable_interrupts ();
> /* 3.2.2. strobe watchdog once */
> WATCHDOG_RESET();
> + base = post_time_ms (0);
> + while (post_time_ms (base) < 2)
> + WATCHDOG_RESET();
Are you absolutely sure that is needed?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Tactical? TACTICAL!?!? Hey, buddy, we went from kilotons to megatons
several minutes ago. We don't need no stinkin' tactical nukes. (By
the way, do you have change for 10 million people?) - lwall
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users
