On 23:21 Mon 14 Apr , Grant Likely wrote: > On Mon, Apr 14, 2008 at 5:28 PM, Guennadi Liakhovetski <[EMAIL PROTECTED]> > wrote: > > On Mon, 14 Apr 2008, Wolfgang Denk wrote: > > > > > In message <[EMAIL PROTECTED]> you wrote: > > > > > > > > > +#if defined(CONFIG_HARD_I2C) && defined (CONFIG_I2C_MXC) > > > > Please stop to define this here, move it the Makefile > > > > > > Hm... While I agree with the simple standard case of a single > > > "#ifdef", I'm not so 100% sure it is a good thing to add such complex > > > expressions to the Makefile. > > > > > > Aren't we just moving the #ifdef hell from one place to another? > > > > Wouldn't it be logical to assume, that if CONFIG_I2C_MXC is defined, > > CONFIG_HARD_I2C is meant too? So, we could just put in i2c.h > > > > #ifdef CONFIG_I2C_MXC > > #define CONFIG_HARD_I2C > > #endif > > > > And then use the simple > > > > OBJC-$(CONFIG_I2C_MXC) += ... > > > > Yes, this is the way I'd solve the problem. I dont't like the idean to modify the i2c.h for each i2c drivers implemetation. I prefer to keep it into the config file and move it to the Kconfig. I hope that I've time the next merge window to send it.
Best Regards, J. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
