In message <[EMAIL PROTECTED]> you wrote: > The primary goal of these changes is to unify some of the low-level > SDRAM and ECC initialization code for the PPC4xx processors that use a > common DDR2 SDRAM controller. > > In particular, in the case of the 405EX[r], it must initialize SDRAM > before a primordial stack is available since OCM doesn't exist and the > data cache does not work for such a purpose. As a consequence, the ECC > (and SDRAM) initialization code must be stack-free.
Stefan already asked this... I would also like to understand why the data cache cannot be used for initial RAM as we do on so many other systems? I hesitate to throw away good C code in favour of hard to read, hard to maintain assembly, especially if this also breaks with some of the U-Boot design principles. > --- > board/amcc/kilauea/init.S | 53 +++++++++++-- > board/amcc/makalu/init.S | 53 +++++++++++-- > cpu/ppc4xx/Makefile | 1 + > cpu/ppc4xx/ecc.S | 195 > +++++++++++++++++++++++++++++++++++++++++++++ > cpu/ppc4xx/sdram.c | 47 +---------- > 5 files changed, 292 insertions(+), 57 deletions(-) There are coding style violations: C++ comments, trailing white space, indentation not consequently by TABs. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Chapter 1 -- The story so far: In the beginning the Universe was created. This has made a lot of people very angry and been widely regarded as a bad move. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
