In message <[EMAIL PROTECTED]> you wrote:
> 
> Signed-off-by: Stelian Pop <[EMAIL PROTECTED]>
> ---
>  include/asm-arm/u-boot.h |    4 ++++
>  lib_arm/board.c          |   14 ++++++++------
>  2 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/include/asm-arm/u-boot.h b/include/asm-arm/u-boot.h
> index c120312..dbfe2cf 100644
> --- a/include/asm-arm/u-boot.h
> +++ b/include/asm-arm/u-boot.h
> @@ -48,10 +48,14 @@ typedef struct bd_info {
>       ulong start;
>       ulong size;
>      }                        bi_dram[CONFIG_NR_DRAM_BANKS];
> +    ulong            bi_dram_size;

Why would that be needed?  Isn't  adding  the  "size"  entries  above
sufficient?

>       for (i=0; i<CONFIG_NR_DRAM_BANKS; i++) {
> -             size += gd->bd->bi_dram[i].size;
> +             gd->bd->bi_dram_size += gd->bd->bi_dram[i].size;
>       }
>       puts("DRAM:  ");
> -     print_size(size, "\n");
> +     print_size(gd->bd->bi_dram_size, "\n");

We really don't need an extra variable here, me thinks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
You can't evaluate a man by logic alone.
        -- McCoy, "I, Mudd", stardate 4513.3

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
U-Boot-Users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to