Ben, On Thu, 2008-05-15 at 13:50 -0700, Ben Warren wrote: > > -#ifdef CONFIG_HAS_ETH0 > > #define CONFIG_ETHADDR 00:E0:0C:00:95:01 > > -#endif > > - > > -#ifdef CONFIG_HAS_ETH1 > > #define CONFIG_ETH1ADDR 00:E0:0C:00:95:02 > > -#endif > > > Please also remove the default MAC address assignments.
I think we need them, don't we? > > > > #define CONFIG_IPADDR 10.0.0.2 > > #define CONFIG_SERVERIP 10.0.0.1 > > > While you're at it, putting default IP addresses is also pointless. At least it tells you that you can put your address here. It doesn't hurt. And BTW, I want to make my patch as small as possible. I'll leave the rest to the board maintainer. York ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
