Wolfgang Denk wrote: >> plus, it looks like the patch is replacing tabs with spaces (see, e.g., >> pib_init() changes in board/freescale/mpc8349emds/pci.c). > > Hm...
[snip] > Argghhh.... No, really not. Thanks for cathing this one. It skipped > both my automatic and manual verification :-( > > > Patch version 2 available at > ftp://ftp.denx.de/pub/tmp/big-white-space-cleanup.patch-v.2.gz I started to check some MIPS related file, and immediately found wrong fixes. board/purple/purple.c ... cache_unroll cpu/mips/asc_serial.c ... TOUT_LOOP, FBS_ISR, many others! cpu/mips/start.S ... All tabs removed!!! : : [stop further review at this point] Let me confirm whether above is intentional change or not, please? I'm afraid it's better to leave them as they are, even if there are silly white-space issues left. Shinya ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
