On Jun 10, 2008, at 12:57 AM, Kim Phillips wrote: > On Thu, 29 May 2008 03:20:08 -0500 (CDT) > Kumar Gala <[EMAIL PROTECTED]> wrote: > >> +struct cpu_type cpu_type_list [] = { >> + CPU_TYPE_ENTRY(8533, 8533, 0), >> + CPU_TYPE_ENTRY(8533, 8533_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8540, 8540, 0), >> + CPU_TYPE_ENTRY(8541, 8541, 0), >> + CPU_TYPE_ENTRY(8541, 8541_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8543, 8543, 0), >> + CPU_TYPE_ENTRY(8543, 8543_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8544, 8544, 0), >> + CPU_TYPE_ENTRY(8544, 8544_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8545, 8545, 0), >> + CPU_TYPE_ENTRY(8545, 8545_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8547, 8547_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8548, 8548, 0), >> + CPU_TYPE_ENTRY(8548, 8548_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8555, 8555, 0), >> + CPU_TYPE_ENTRY(8555, 8555_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8560, 8560, 0), >> + CPU_TYPE_ENTRY(8567, 8567, 0), >> + CPU_TYPE_ENTRY(8567, 8567_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8568, 8568, 0), >> + CPU_TYPE_ENTRY(8568, 8568_E, CPU_FTRS_HAS_CRYPTO), >> + CPU_TYPE_ENTRY(8572, 8572, 0), >> + CPU_TYPE_ENTRY(8572, 8572_E, CPU_FTRS_HAS_CRYPTO), > > this seems like overkill given all we have to do is check one bit (see > IS_E_PROCESSOR macro in "handle crypto node" patch I just sent out).
I don't trust our HW guys to keep w/that convention. Plus we can use this mechanism for other things if need be. - k ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users