On Tue, 2008-06-10 at 07:03 -0700, Ben Warren wrote: > +#if defined(CONFIG_TSEC1) > + tsec_initialize(bis, 0, CONFIG_TSEC1_NAME); > +#endif > +#if defined(CONFIG_TSEC2) > + tsec_initialize(bis, 1, CONFIG_TSEC2_NAME); > +#endif > +#if defined(CONFIG_MPC85XX_FEC) > + tsec_initialize(bis, 2, CONFIG_MPC85XX_FEC_NAME); > +#else > +#if defined(CONFIG_TSEC3) > + tsec_initialize(bis, 2, CONFIG_TSEC3_NAME); > +#endif > +#if defined(CONFIG_TSEC4) > + tsec_initialize(bis, 3, CONFIG_TSEC4_NAME); > +#endif > +#endif > + return 0; > +}
So, why not make a new function in tsec.c called something like tsec_initialize_all(bis) with essentially the above #ifdef-series and make all of the individual board functions just be like: +int board_eth_init(bd_t *bis) +{ + tsec_initialize_all(bis); + return 0; +} Just a notion. Haven't actually thought about it... jdl ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users