On 6/11/08 4:00 PM, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you > wrote: >> Added preprocessor definitions for External Bus Controller (EBC) >> configuration, bank configuration and access parameter register fields >> along with a macro for defining them and verifying them against the >> data sheet or user's manual easier. >> >> Tested against AMCC "Haleakala". >> >> Signed-off-by: Grant Erickson <[EMAIL PROTECTED]> > > Are these definitions being used anywhere? > > I tend to drop this patch because it seems to be just dead code. > Stefan, do you agree? > > > Best regards, > > Wolfgang Denk
Wolfgang, These are actually now used in cpu/ppc4xx/start.S and are probably already included in the latest 4xx pull from Stefan. So, this patch might be a no-op at this point. Regardless, while they are not used in include/configs/kilauea.h and include/configs/makalu.h yet (but both could and should be) I have used them in the include/config/<board>.h for the new boards I am supporting for a client. They make it much easier to decode BxAP and BxCR settings than an arbitrary 32-bit hex value. Regards, Grant ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
