Menon, Nishanth wrote:
> Robert,
>> -----Original Message-----
>> From: Robert Schwebel [mailto:[EMAIL PROTECTED]
>> Sent: Wednesday, June 18, 2008 2:02 PM
>> To: Menon, Nishanth
>> Cc: Sascha Hauer; Laurent Desnogues; Kamat, Nishant; [EMAIL PROTECTED]; 
>> u-boot-
>> [EMAIL PROTECTED]
>> Subject: Re: [U-Boot-Users] [Patch 1/9] U-boot-V2:ID: Sync mod_devicetable
>>
>>> +
>>> +#ifndef LINUX_MOD_DEVICETABLE_H
>>> +#define LINUX_MOD_DEVICETABLE_H
>>> +
>>> +#ifdef __KERNEL__
>>> +#include <linux/types.h>
>>> +typedef unsigned long kernel_ulong_t;
>>> +#endif
>> No Linux, no __KERNEL__.


All the above crap should appear below the following "---" line.

> Here is a patch to cleanup all other occurrences currently in u-boot v2. This 
> is a blind replacement throughout. Do we want to consider replacing 
> include/linux with include/u-boot?

That should be line-length-limited to about 70 characters.
The question should appear below the "---" line too.

And I'd suggest that, if we go this route as a whole, then
then the include directory should be renamed as well.

> Signed-off-by: Nishanth Menon <[EMAIL PROTECTED]>
> 
> ---

Here.

jdl

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Reply via email to