On Thursday 10 July 2008, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > > This patch now moves common.h to the top of the inlcude list. This > > is needed for boards with CONFIG_PHYS_64BIT set (e.g. katmai), so that > > the phys_size_t/phys_addr_t are defined to the correct size in this > > driver. > > > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > > --- > > cpu/ppc4xx/4xx_pcie.c | 6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > Hm. I think we have a serious problem when the correctness of the code > depends on the include order. It seems that include/asm-ppc/types.h > depends on CONFIG_PHYS_64BIT, so include/asm-ppc/types.h must make > sure this variable is set correctly, i. e. we should include common.h > there.
Yes, I though too that this problem might affect other files too. But unfortunately including common.h from within asm/types.h does not work since common.h includes (and needs) types.h itself. I have no elegant solution to handle this in a more generic way right now. Perhaps somebody else has? Ideas welcome. :) Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] ===================================================================== ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ U-Boot-Users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/u-boot-users
