In message <[EMAIL PROTECTED]> you wrote: > commit d66194654186b0e82d926ce4844b73e3508397f4 > Parent: 699f05125509249072a0b865c8d35520d97cd501 > Author: Ryan Chen <[EMAIL PROTECTED]> > Date: Tue Jul 29 13:35:15 2008 -0400 > > Signed-off-by: Ryan Chen <[EMAIL PROTECTED]> > > new file: board/st/stls/Makefile > new file: board/st/stls/config.mk > new file: board/st/stls/u-boot.lds.S
Please use git-format-patch to format the patch. Above text is NOT an acceptable commit message. > +######################################################################### > diff --git a/board/st/stls/config.mk b/board/st/stls/config.mk > new file mode 100755 > index 0000000..683b009 > --- /dev/null > +++ b/board/st/stls/config.mk ... > +#GUI_SUPPORT = minigui > \ No newline at end of file ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Please fix this!! > diff --git a/board/st/stls/u-boot.lds.S b/board/st/stls/u-boot.lds.S > new file mode 100755 > index 0000000..5e7bb76 > --- /dev/null > +++ b/board/st/stls/u-boot.lds.S Why not u-boot.lds like for all the other boards? The ".S" suffix suggests it is an assembler file, which it ain't. Hm... This patch is incomplete, as it does not add all filkes needed to support this board. On the other hand, it is not part of a patch series (at least it is not m,arked as such, and not threaded accordingly). Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] (null cookie; hope that's ok) ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
