Hi, >Please move such comments *below* the '---' line. Anything ABOVE '---' >will become the commit message that goes into the repository, only stuff below the '---' gets ignores as comment.
Yes i will do & re-submit >> drivers/rtc/Makefile | 1 + >> drivers/rtc/rtc_pl031.c | 123 +++++++++++++++++++++++++++++++++++++++++++++++ >> board/versatile/versatile.c | 9 +++++++++ >> include/configs/versatile.h | 7 +++++++ > >So this is actually not a single patch, but TWO: Peter Pearse & Jean-Christophe PLAGNIOL-VILLARD had asked me to the board details which will be using it. So i added it here. I already sent a separate Versatile Board Update Only Code to Peter Pearse but not received any update from him. >So please split your patch and submit as two separate patches. Ok will do that >> +#if defined(CONFIG_RTC_PL031) && defined(CONFIG_CMD_DATE) >> + rtc_init(); >> +#endif > >Why do we need the #ifdef's here? It seems this is a board specific configuration anyway, i. e. we don't expect for example other RTC chips to be used on this board, or do we? If the user doesn't Need to Use RTC, He can Just disable it from Versatile Board Config file versatile.h. This was my Idea. Isn't it required Regards Gururaja ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
