Dear Ryan, in message <[EMAIL PROTECTED]> you wrote: > Hi Wolfgang, > I have modified my patch. New macro "CONFIG_SM501_ENABLE_2DENGINE" be > included to specify codes what enable SM501 2D engine. The macro need be > declared in config header file. > Why does it need to enable 2D engine? The reason is most of framebuffer > contents need be moved in VRAM when screen scrolls up. The work be done by > software in current U-Boot for SM501. The patch is to enable 2D engine to do > it by hardware without CPU interference. > > Signed-off-by: Ryan Chen <[EMAIL PROTECTED]>
Could you please use git-format-patch to create the patch, and git-send-email to send it? This might avoid problems like the line wrapping - see below. Also, please spend a few seconds on thinking about which text you want to see in the commit message. As submitted here, the whole text: Hi Wolfgang, I have modified my patch. ... ... Signed-off-by: Ryan Chen <[EMAIL PROTECTED]> would make it into the commit message. I do not think that was your intention. Comments about the patch etc. should go *below* the "---" line that gets inserted by git-format-patch. Well, but the real problem with your poatch is here: ... > +#define FIELD_SIZE(field) (1 + FIELD_END(field) - > FIELD_START(field)) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_MASK(field) (((1 << (FIELD_SIZE(field)-1)) | > ((1 << (FIELD_SIZE(field)-1)) - 1)) << FIELD_START(field)) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_NORMALIZE(reg, field) (((reg) & FIELD_MASK(field)) >> > FIELD_START(field)) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_DENORMALIZE(field, value) (((value) << FIELD_START(field)) & > FIELD_MASK(field)) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_INIT(reg, field, value) FIELD_DENORMALIZE(reg ## _ ## > field, \ ^^^^^^^^^^^^^^^^^^^^^^^ > + reg ## _ ## field > ## _ ## value) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_INIT_VAL(reg, field, value) \ > + (FIELD_DENORMALIZE(reg ## _ ## > field, value)) ^^^^^^^^^^^^^^^^^^^^^^^ > +#define FIELD_VAL_SET(x, r, f, v) x = x & ~FIELD_MASK(r ## _ ## f) \ > + | FIELD_DENORMALIZE(r ## _ ## > f, r ## _ ## f ## _ ## v) ^^^^^^^^^^^^^^^^^^^^^^^ And so on - your mailer is wrapping long lines, thus corrupting the patch. It's unusable as is. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] There are always alternatives. -- Spock, "The Galileo Seven", stardate 2822.3 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users