Hi Nobuhiro, Nobuhiro Iwamatsu wrote: > Hi, Peter. > > On Tue, 28 Oct 2008 09:36:10 -0500 > Peter Tyser <[EMAIL PROTECTED]> wrote: > > >> Hi Nobuhiro, >> The titles for this patch series should be renamed with s/Moveed/Moved/ >> and maybe s/in/to/. >> > Oh, Thanks. > > >> Also, git should be smart enough to know the files were moved as opposed >> to separate file deletions/creations. For example from "[PATCH 01/12] >> gunzip: move to lib_generic": >> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]> >> --- >> common/Makefile | 1 - >> lib_generic/Makefile | 1 + >> {common => lib_generic}/gunzip.c | 0 >> 3 files changed, 1 insertions(+), 1 deletions(-) >> rename {common => lib_generic}/gunzip.c (100%) >> >> diff --git a/common/Makefile b/common/Makefile >> index 944b1c0..d974823 100644 >> --- a/common/Makefile >> +++ b/common/Makefile >> @@ -36,7 +36,6 @@ COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o >> COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o >> COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o >> COBJS-y += image.o >> -COBJS-y += gunzip.o >> COBJS-y += cmd_boot.o >> COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o >> COBJS-y += cmd_bootm.o >> diff --git a/lib_generic/Makefile b/lib_generic/Makefile >> index bf0e31d..a820f97 100644 >> --- a/lib_generic/Makefile >> +++ b/lib_generic/Makefile >> @@ -34,6 +34,7 @@ COBJS-y += crc32.o >> COBJS-y += ctype.o >> COBJS-y += display_options.o >> COBJS-y += div64.o >> +COBJS-y += gunzip.o >> COBJS-y += lmb.o >> COBJS-y += ldiv.o >> COBJS-$(CONFIG_MD5) += md5.o >> diff --git a/common/gunzip.c b/lib_generic/gunzip.c >> similarity index 100% >> rename from common/gunzip.c >> rename to lib_generic/gunzip.c >> >> >> Maybe you have to explicitly use the "git mv" command, I'm not sure... >> Without git noticing the files were only moved I'm doubtful the moved >> files would retain their history log and only having the relevant file >> changes in the diff would clean up the patches significantly. >> > OK, I will check and resend. > > Thnak you for your check. > > Best regards, > Nobuhiro > Use 'git mv' and then 'git format-patch -C'
regards, Ben _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot