On 12:56 Wed 17 Dec , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <1229513662-2128-1-git-send-email-plagn...@jcrosoft.com> you wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagn...@jcrosoft.com> > > --- > > common/cmd_i2c.c | 58 > > ++++++++++++++++++++++++++--------------------------- > > 1 files changed, 28 insertions(+), 30 deletions(-) > > > > diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c > > index 448f2fe..9f7a1ea 100644 > > --- a/common/cmd_i2c.c > > +++ b/common/cmd_i2c.c > > @@ -712,7 +712,7 @@ static void decode_bits (u_char const b, char const > > *str[], int const do_once) > > */ > > int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) > > { > > - enum { unknown, EDO, SDRAM, DDR2 } type; > > + enum { unknown, edo, sdram, ddr2 } type; > > Sorry again, but lower case enum labels violate the coding style > either: > > Chapter 12: Macros, Enums and RTL > > Names of macros defining constants and labels in enums are > capitalized. so could you tell what do you wish to have (an example) __DDR2?
Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot