On Friday 12 December 2008 02:22:16 Wolfgang Denk wrote: > In message <200812112130.02918.vap...@gentoo.org> you wrote: > > > > -#ifndef CONFIG_SF_DEFAULT_SPEED > > > > -# define CONFIG_SF_DEFAULT_SPEED 1000000 > > > > +#ifndef CONFIG_SF_DEFAULT_HZ > > > > +# define CONFIG_SF_DEFAULT_HZ 1000000 > > > > > > I consider "FREQ" (and even "SPEED) a much better name than "HZ". > > > > > > "HZ" is the unit of what you are measuring, not a name for what you > > > are measuring. > > > > then they should all be converted. not 90% using hz and 10% using > > something > > Agreed. > > > else. "speed" is bad as it doesnt convey the unit while "hz" is pretty > > clear. > > You are right, but that could be mentioned in the documentation > then...
that seems silly to me. we can either have self-explaining defines, or confusing ones which requires people to read the documentation to figure out ? -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
