Dear Mike Frysinger,
In message <200901291605.09474.vap...@gentoo.org> you wrote:
>
> > Rather:
> >
> > - misc_init_r() [or similar] sets up ethaddr in env if it isnt
> > set already and sets bi_enetaddr in global data
> > - board_eth_init() calls the driver init
> > (bfin_EMAC_initialize() in your case)
> > - driver init looks up ethaddr in env or bi_enetaddr
>
> well this gets us into the realm of what i was trying to avoid/fix in the
> first place: duplication of the env/ethaddr handling/parsing code. i get
What is wrong with using bi_enetaddr? What sort of "handling/parsing
code" (in addition to a plain simple memcpy(...,6) is needed?
> tired of auditing every board/driver just to find the same simple bugs were
> duplicated and/or not handled properly.
I lost you here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Conquest is easy. Control is not.
-- Kirk, "Mirror, Mirror", stardate unknown
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
