On Wednesday 11 February 2009 16:43:51 Wolfgang Denk wrote:
> In message Mike Frysinger you wrote:
> > +#define SWITCH_BANK do { if (memIndex >= 0x20200000) {\
> > + *pPORTFIO_SET = GPIO_4; \
> > + memIndex -= 0x200000; \
> > + crossed = 1;\
> > + } else { \
> > + *pPORTFIO_CLEAR = GPIO_4; \
> > + } \
> > + asm("ssync;"); } while (0)
> > +
> > +#define SWITCH_BACK do {if (crossed) {\
> > + *pPORTFIO_CLEAR = GPIO_4; \
> > + memIndex += 0x200000; \
> > + crossed = 0;\
> > + asm("ssync;");\
> > + } } while (0)
>
> Please use accessor functions instead of pointer accesses (which alslo
> will allow you to get rid of the "ssync" stuff here).the ssync would still be required. it's to force the GPIO pins to the proper state, not to make sure some address request has gone out. all the flash drivers in the tinyboard dirs (cm-*) are "throw away" ... they all exist because a common driver does not yet exist to hook CFI compliant flashes up partially with addressing lines and partially with GPIOs. once i get around to implementing that, all of these can be summarily scuttled. sorry, i should have noted this in the summary. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
