-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/27/12 21:50, Marek Vasut wrote: > Dear Pantelis Antoniou, > >> Call usb_gadget_connect/usb_gadget_disconnect in >> g_dnl_bind/g_dnl_unbind. >> >> Signed-off-by: Pantelis Antoniou <pa...@antoniou-consulting.com> > [...] > > u-boot$ ./tools/checkpatch.pl \[PATCH\ 8_9\]\ Issue\ > connect_disconnect\ as\ appropriate.mbox WARNING: line over 80 > characters #57: FILE: drivers/usb/gadget/g_dnl.c:88: + > debug("%s: calling usb_gadget_disconnect for controller '%s'\n", > shortname, gadget->name); > > WARNING: line over 80 characters #67: FILE: > drivers/usb/gadget/g_dnl.c:160: + debug("%s: calling > usb_gadget_connect for controller '%s'\n", shortname, > gadget->name); > > total: 0 errors, 2 warnings, 21 lines checked >
Going over the limit is OK for prints to increase grepability. Unless splitting at the arguments would fix it. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQtX8HAAoJENk4IS6UOR1WddgQAIwTWvCvLrKCAwIuPNoWQrWv SQd0Pp9cQqrEgIdNRq+qwDMO1drD40w/zZEpo21tPXtWIwHLgfEz2JAfEXRPJh0P 71hjKAQUq7Y4kkseu1Hx0qH1bmt1ILv6qZw3PHCuHGcD534kp2XegHXRnxvLho64 ucluUjcf5sYiCmp1Wfb7mRJe+qojQm6Njbx2RxyEb/5KyNuvlzYfb/Pu+QztrdYc ku52fFf4DLBhgoYcRbUaVk9GqloeZkf6UkWbwEJQjfkxS6F32sH7Ye1/F260RBe4 jbDmmhTKNe+FTftO17N0KULdeML2nRxwDP7hv1BrE/M/WoMQvSmPavZ6X+JUJ3wb pLrvRTrui3uohESiicVCsBjZyIMqd4rX58El9PzrXBIFdsvrJnfG1yopSzDLZ4Gu /QCpkkUzG5FsPwA0bc5CCmaD9vAqp5Pv9VN59K9Q949hKasOv7qmPMRKqmBFAZDg t0W7xTbh9tkOGA2oDDU6pmNAfptwIns/4FX0Gxko/3Di3BO+vW6HKqYIJND4FbEE i3JOrMrDkT1Kse3PNevSxZ2HMb2N7ALe/HnECp4wLnorRKlyavhYfqHs+lklCJDV gfaocfzxyFjzXnEpxGqlbBZpNyH65+YSZP7Y/8UCkgs1Sp9N9SzdGCobFDlmzJwa Z8ZFbT1FWw0pf9kEfYM+ =XhQi -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot