Dear Lukasz Majewski, In message <20121210103224.372c572e@amdc308.digital.local> you wrote: > > > This is unrelated to your patch - but what if pmic_get() returns NULL? > > > > pmic_probe() will crashif you pass it a NULL pointer... > > The PMIC 2.0 uses malloc to allocate pmic structure.
...and malloc() can fail. > The fix, which has been proposed would work for old pmic. > > In the new one PMIC 2.0, we require to test return pointer from > pmic_get() (similar to all malloc allocations): > > struct pmic *p = pmic_get("MAX8998_PMIC"); > if (!p) > return -ENODEV; So this code here needs fixing. This is what I wanted to point out. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "If you want to eat hippopatomus, you've got to pay the freight." - attributed to an IBM guy, about why IBM software uses so much memory _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot