Hi Wolfgang Denk, On Thu, Dec 20, 2012 at 4:46 AM, Wolfgang Denk <w...@denx.de> wrote: > Dear Jagannadha Sutradharudu Teki, > > In message <1355934463-24319-1-git-send-email-jagannadh.t...@gmail.com> you > wrote: >> This patch adds a print messages while using 'sf erase' command >> to make sure that how many bytes erased in flash device. >> >> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.t...@gmail.com> >> --- >> Changes in v2: >> Move print messages from spi_flash.c into cmd_sf.c > > This makes little sense to me. Please see all comments here: > > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149663 > > and here: > > http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149665
I thought these are useful verbose prints for sf read/write/erase commands as there is no verbose support before. Like NOR, NAND and SD have some verbose prints while executing respective commands This is the only way to know the user whether these commands are - executed properly - what is the status after executing (success/fail, how many bytes read/write/erase. etc) Due to the above reasons I have added these verbose support. Apart from this sometimes (very rare) due to the slowness of UART or SPI flash even if we run the sf commands it will not execute the actual code just terminate with showing u-boot prompt, so the user assumes that this command is happen properly. [but actually command is not done] I thought these verbose prints will help such wild scenarios. Correct me if am wrong with my thinking. Thanks, Jagan. > > > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii) > "That we but teach bloody instructions, > which, being taught, return to plague the inventor..." _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
