Hi Marek, On Sat, Jan 5, 2013 at 12:19 AM, Marek Vasut <ma...@denx.de> wrote: > Dear Simon Glass, > > [...] > >> + int string_size; >> + int ret; >> + >> + /* >> + * Get the current string size, before we update the FIT and add >> + * more >> + */ >> + string_size = fdt_size_dt_strings(fit); >> + >> + ret = fdt_setprop(fit, noffset, FIT_VALUE_PROP, value, value_len); >> + ret |= fdt_setprop_string(fit, noffset, "signer-name", "mkimage"); >> + ret |= fdt_setprop_string(fit, noffset, "signer-version", >> + PLAIN_VERSION); > > Can you really be ORR'ing a signed variable such as "ret" ?
It's pretty ugly, and it means that I don't get a proper error message, so I will change it, particularly as this is only used by mkimage and code size is not a concern. Thanks very much for reviewing these patches, and for comments. The image code is actually mostly pretty nice so it hasn't been difficult to work with. Regards, Simon > [...] > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot