On Thu, Jan 24, 2013 at 11:13:27AM -0800, York Sun wrote: > On 01/24/2013 11:09 AM, Scott Wood wrote: > > On 01/24/2013 12:47:10 PM, York Sun wrote: > >> diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py > >> index d831087..28b3240 100644 > >> --- a/tools/patman/checkpatch.py > >> +++ b/tools/patman/checkpatch.py > >> @@ -48,12 +48,12 @@ def FindCheckPatch(): > >> print 'Could not find checkpatch.pl' > >> return None > >> > >> -def CheckPatch(fname, verbose=False): > >> +def CheckPatch(fname, verbose=false): > >> """Run checkpatch.pl on a file. > >> > >> Returns: > >> 4-tuple containing: > >> - result: False=failure, True=ok > >> + result: false=failure, true=ok > >> problems: List of problems, each a dict: > >> 'type'; error or warning > >> 'msg': text message > > > > You should probably limit the change to C code. :-) > > > Nice catch. I forgot Python use True and False. Will fix. >
Omit tools/bddb/defs.php as well. I'm still not clear what the policy should be regarding 3rd party libraries that are checked into u-boot, but my opinion is they should stay as close to the original source as much as possible, so we should exclude them from this cleanup: lib/bzlib.c | 76 +++++----- lib/bzlib_decompress.c | 20 +-- lib/bzlib_huffman.c | 8 +- lib/bzlib_private.h | 3 - lib/lzma/LzmaDec.c | 2 +- lib/lzma/Types.h | 3 - -Allen -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot