Dear Angelo Dureghello, In message <20130125104307.GA3223@sion.sysam> you wrote: > Add support for Sysam AMCORE mcf5307 (coldfire) based board.
Sorry for the late catch - this escaped me so far... > Changes for v5: > - Fix MAINTAINERS bad sorted entry > - Fix incorrect indentation > - Remove #undef where not needed Did you? I still see some... > +#if defined(CONFIG_SYS_DRAM_TEST) > +/* memory test */ > +int testdram(void) ... > +#endif This is: 1) dead code, as you don't define CONFIG_SYS_DRAM_TEST 2) an obsolete approach that you should not use. We have a several different (and much more reliable) memory tests already - if yuou really need one, then please use the existing code. On the other hand, you are using get_ram_size, which already includes a simple memory test - so re you sure you really need an extra test? > +#undef CONFIG_SYS_DRAM_TEST /* default undef */ ==> remove. > +/* bypass PLL for test purpose */ > +#undef CONFIG_SYS_PLL_BYPASS ??? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The light at the end of the tunnel is usually a "No Exit" sign. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot